LPS-75193 Announcements portlet's Distribution Scope is "General" regardless where it is placed #612
Conversation
…r will still work
…anks when staging
…sageListener was created
…guration values in RecentDocumentsMessageListener
…endent module, in order to enable or disable we need to enable or disable the module, but we don't need a property to do that
…creating a wrapper in documents and media to use the new modules
…creating a wrapper in documents and media to use the new modules
…ion file in the dl file rank service.
…ardless where it is placed
…et in order to prevent naming conflict with the "group" variable defined in init.jsp
|
Pull request test invoked at http://test-1-2.liferay.com/job/test-portal-acceptance-pullrequest(master). |
|
Just started reviewing :) |
Sent from
|
Hi @IstvanD The code looks perfect but we are not going to introduce this in master: After talk about the expected behavior with @sergiogonzalez we have agreed that in this case, change the current behaviour could be a bit confusing, since this is an arbitrary decision. For example, we decided to use the current group, but following the same reasoning, why don't we use the role of the current user? Since that we tend to think that the general scope is the most accurate as default scope, so we think that we have nothing to fix in master, and we should backport this behaviour to 7.0.x. Can you send me a PR to the ee repo with this changes?? Thanks! |
|
Hi @robertoDiaz I've send the pull https://github.com/robertoDiaz/liferay-portal-ee/pull/49. |
|
Thanks to you! |
Hey @robertoDiaz
I applied logic directly from the Social Office Announcements portlet to the Announcements portlet to auto-select the distribution scope based on the Site the portlet is placed.
Could you please review it?
Thank you,
István