Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Implement a simple HttpClient wrapper as an alternative to using a proxy #40

Closed
robfletcher opened this Issue · 4 comments

1 participant

@robfletcher
Owner

In many scenarios it would be trivial to inject a Betamax wrapper around a standard HttpClient instance into the class-under-test. This would be simpler than spinning up a proxy server and could share all the same functionality.

@robfletcher robfletcher was assigned
@robfletcher
Owner

Following recent refactoring this is almost trivial to implement so I might do so for 1.1

@robfletcher robfletcher referenced this issue from a commit
Rob Fletcher Proof of concept implementation for #40 f9eb010
@robfletcher robfletcher referenced this issue from a commit
Rob Fletcher more implementation for #40 c62bb6f
@robfletcher robfletcher referenced this issue from a commit
Rob Fletcher preliminary doc changes for #40 766f465
@robfletcher
Owner

Since SystemDefaultHttpClient exists I don't think there's any need for this.

@robfletcher
Owner

whoops, that was completely the wrong issue I closed

@robfletcher robfletcher reopened this
@robfletcher robfletcher referenced this issue from a commit
Rob Fletcher #40 pick up `useProxy` from config 91876e3
@robfletcher robfletcher referenced this issue from a commit
Rob Fletcher #40 document `useProxy` flag ccc8e36
@robfletcher robfletcher referenced this issue from a commit
Rob Fletcher docs for #40 9119185
@robfletcher
Owner

This is in master now (and deployed as Betamax 1.2-SNAPSHOT).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.