Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make expectThat(subject, block) return Unit #190

Closed
RamazanYapparov opened this issue Oct 24, 2019 · 1 comment
Closed

Make expectThat(subject, block) return Unit #190

RamazanYapparov opened this issue Oct 24, 2019 · 1 comment
Labels
💥 breaking change Will change APIs in a non-backward compatible way 🦄 enhancement New feature or request

Comments

@RamazanYapparov
Copy link
Contributor

Hi! Can you please consider making expectThat(subject, block) return Unit instead of DescribeableBuilder. Or add different Unit returning method with the same behaviour.

The problem is when using this method in test which body is basically runBlocking suspend block. In this case if the assertion is the last statement the block returns the DescribeableBuilder from the test method, and JUnit doesn't call non void (non Unit in this case) test methods during test phase.

@robfletcher robfletcher added the 🦄 enhancement New feature or request label Nov 23, 2019
@robfletcher
Copy link
Owner

Yeah, that seems reasonable. I'll check that it's not breaking anything vital.

@robfletcher robfletcher added the 💥 breaking change Will change APIs in a non-backward compatible way label Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥 breaking change Will change APIs in a non-backward compatible way 🦄 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants