Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures for not() do not report the actual value #222

Closed
dhleong opened this issue Jun 7, 2020 · 2 comments
Closed

Failures for not() do not report the actual value #222

dhleong opened this issue Jun 7, 2020 · 2 comments
Labels
🐛 bug Something isn't working

Comments

@dhleong
Copy link

dhleong commented Jun 7, 2020

For example, expectThat(...).get(Screen::contents).contains() might result in:

▼ Expect that Screen@453d496b:
  ▼ contents:
    ✗ contains "error"
         found "My value
               |
               |Success
               |"

but adding not() in there results in simply:

▼ Expect that Screen@191a709b:
  ▼ contents:
    ✗ does not contain "error"
@robfletcher robfletcher added the 🐛 bug Something isn't working label Aug 18, 2020
@robfletcher
Copy link
Owner

This is to some extent dependent on how individual assertions are implemented, but I've updated the framework and all the assertions in the standard library to support this.

@dhleong
Copy link
Author

dhleong commented Sep 13, 2020

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants