Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

booleanValue().isFalse() can pass inappropriately #225

Closed
robfletcher opened this issue Aug 17, 2020 · 1 comment
Closed

booleanValue().isFalse() can pass inappropriately #225

robfletcher opened this issue Aug 17, 2020 · 1 comment
Assignees
@robfletcher
Labels
🐛 bug Something isn't working

Comments

@robfletcher
Copy link
Owner

Because Jackson's default implementation of booleanValue() is to return false, the assertion should also check that it has a BooleanNode.
@robfletcher robfletcher added the 🐛 bug Something isn't working label Aug 17, 2020
@robfletcher robfletcher self-assigned this Aug 17, 2020
@robfletcher
Copy link
Owner Author

This is annoying but consistent with Jackson. Not sure if it makes sense to change the behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robfletcher robfletcher

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robfletcher