Skip to content
This repository has been archived by the owner. It is now read-only.

fix message logging and filtering #31

Open
2 of 3 tasks
robgjansen opened this issue Apr 5, 2017 · 1 comment
Open
2 of 3 tasks

fix message logging and filtering #31

robgjansen opened this issue Apr 5, 2017 · 1 comment
Assignees
@robgjansen
Labels
bug

Comments

Assignees

@robgjansen robgjansen

Labels
bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@robgjansen @irl
@robgjansen
Copy link
Owner

@robgjansen robgjansen commented Apr 5, 2017 •
edited

When running in measurement mode, new analysis results are produced every night at midnight utc. However, in cases when OnionPerf was not running at midnight and restarts on a later day, log messages from both partial days appear in the same log file. When the analysis is run at the midnight following the day it was restarted, downloads from the day it was first stopped may appear in the analysis results (the .tpf files).

We should fix this.

  • allow onionperf analysis mode to filter out log messages that do not match a certain date; onionperf measurement mode should take advantage of that feature
  • When exporting Torperf .tpf files, and a date filter is applied, we need to ensure that we do not include downloads that started on a different day (to handle the case where it ended on the filtered date but started on the previous day)
  • onionperf should name the log files according to the date of the log message timestamps, and each log message should only be appended to the file corresponding to that date
@robgjansen robgjansen added the bug label Apr 5, 2017
@robgjansen robgjansen changed the title message logging and filtering fix message logging and filtering Apr 5, 2017
robgjansen added a commit that referenced this issue Apr 5, 2017
@robgjansen
allow manual specification of date filtering for analysis
e2d552b 
refs #31
@robgjansen robgjansen self-assigned this Apr 6, 2017
robgjansen added a commit that referenced this issue Apr 12, 2017
@robgjansen
handle edge case when filtering downloads by date
8b1abb1 
When exporting tpf files and a date filter is being applied, don't
export downloads that may have ended on the correct date but
started on a previous date.

refs #31
@irl
Copy link
Contributor

@irl irl commented Feb 7, 2019

This issue is now being tracked at https://trac.torproject.org/projects/tor/ticket/29369

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.