Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemas: update 'linux,usable-memory-range' node schema #19

Open
wants to merge 1 commit into
base: master
from

Conversation

@cz-chenzhou
Copy link

cz-chenzhou commented Jun 28, 2020

After support reserving memory above 4G on arm64 kdump, there may
be two usable memory regions in crash dump kernel, update the
'linux,usable-memory-range' node schema.

Signed-off-by: Chen Zhou chenzhou10@huawei.com

@@ -86,13 +86,15 @@ properties:
linux,usable-memory-range:
allOf:
- $ref: types.yaml#definitions/uint64-array
- maxItems: 2
- maxItems: 4

This comment has been minimized.

@robherring

robherring Jun 30, 2020 Owner

I don't think we need to change the limit to 2 ranges, but allow for N ranges. The type should be changed to uint64-matrix with the constraints like this:

items:
  maxItems: 2

This comment has been minimized.

@cz-chenzhou

cz-chenzhou Jul 2, 2020 Author

Ok, allow for N ranges and then limit in kernel.
I take a look at the memory nodes, in the memory nodes, if we could also do like the way you mentioned above.

properties:
  $nodename:
    pattern: "^memory(@[0-9a-f]+)?$"
  device_type:
    const: memory
  reg:
    minItems: 1
    maxItems: 1024
After support reserving memory above 4G on arm64 kdump, the usable
memory regions in crash dump kernel may be more than one, update the
'linux,usable-memory-range' node schema.

Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
@cz-chenzhou cz-chenzhou force-pushed the cz-chenzhou:master branch from 1bd52d7 to b342bc1 Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.