qca-nss-ecm: resolve the cpu high load regarding ecm

[kirdesde]

this is based on quarky's patch for NSS 11.2 (just adapted to nss 11.4)

If using ECM, cpu load goes up (around 1.0) and stucks there. This is due to using uninterruptible sleep function, the patch changes this to interruptible sleep function.

-> https://github.com/quarkysg/openwrt/blob/master-ipq806x-nss-qsdk11/package/qca/qca-nss-ecm/patches/200-resolve-high-load.patch

Signed-off-by: Dirk Buchwalder buchwalder@posteo.de

[castiel652]

Please change the commit title to something that looks like this: qca-nss-ecm: resolve the cpu high load and describe why this patch is needed in the commit message.
add your sign off after you finish above.

[robimarko]

@kirdesde @castiel652 Pretty much told you what I would have told you.
You changed the PR but not the commit itself.

Please, update the patch numbering and name as well as commit message and SoB.

[kirdesde]

I force pushed the commit changes as well as the changed patch numbering. I hope it's all right now.

[robimarko]

Ok, its moving in the right direction.
However, can you limit the commit message to 100 characters per line?

Also, the patch itself needs to be applicable with git apply and git am, which means that it has to be exported with git format patch.
Currently, it's lacking the commit name, message, SoB, and hashes that git uses to recreate the tree before applying.

[kirdesde]

I made a new commit, can you skip that first old commit and only pull that new commit?

Otherwise it's better to reject that PR and i would create a new one.

Sorry for all that noise.

[Ansuel]

@kirdesde you are using the web or command git? if you want i can guide you on how to drop them...

[kirdesde]

@kirdesde you are using the web or command git? if you want i can guide you on how to drop them...

I'm using the git command. Yes thanks a guide would be great.

[Ansuel]

@kirdesde considering you have only 2 commits...
git rebase -i HEAD~2

follow instruction on the new view
in details you should replace the first line pick to drop
save
git rebase --continue

and force push
Now you should have only one commit :D

[kirdesde]

Thanks Ansuel, now it's only one commit.
@robimarko : is it fine for you as well?

[robimarko]

Yes, it's supposed to be one commit.
But, in the patch itself, the whole message is in the subject which is incorrect.
Fix that and I will merge it.

[Ansuel]

(git commit --amend)

[kirdesde]

Yes, it's supposed to be one commit.
But, in the patch itself, the whole message is in the subject which is incorrect.
Fix that and I will merge it.

done

[robimarko]

Now you removed the commit message in the patch and replaced it with the subject copy, please leave the message in the patch.

[kirdesde]

Now you removed the commit message in the patch and replaced it with the subject copy, please leave the message in the patch.

done

[robimarko]

Thanks