Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(makefile): update Makefile #10

Merged
merged 1 commit into from May 27, 2020
Merged

chore(makefile): update Makefile #10

merged 1 commit into from May 27, 2020

Conversation

robinjoseph08
Copy link
Owner

what

  • update golangci-lint to latest version
  • disable scopelint for tests because it was failing with: 
    consumer_test.go:120:33  scopelint  Using the variable on range scope `tt` in function literal
    which isnt a problem in our case since the t.Run functions block the range over tests
  • split out installing golangci-lint into its own target
  • fix setup command to install tools in the ./bin directory, to work with modules, and to not rely on realpath

@robinjoseph08 robinjoseph08 merged commit 944b7f7 into master May 27, 2020
@robinjoseph08 robinjoseph08 deleted the cleanup-makefile branch May 27, 2020 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@robinjoseph08