OpenRead with EnableThreadSafeDataConnections = true does ASCII when it shouldn't #428
FTP OS: Linux
FTP Server: inetutils-ftpd
Computer OS: Windows
Download corruption was originally noticed as size expansion by about 1/256 of original size. Further investigation found that the OpenRead which should have defaulted to binary was in ASCII somehow.
The symptom of the undesired
While setting EnableThreadSafeDataConnections = false stops the corruption, it's not totally clear that it's safe for the application, so code change is desired. Primary cause of the problem appears to be Fix download file data type bug. #202 where a commit moved SetDataType to after the CloneConnection for unknown reasons, unless it was to test that the associated CloneConnection enhancement worked.
The suspected cause of the
A fix might be done (and was patched and tested in a debugger) using one or both of these changes:
There's more information available, but that's the summary. Thanks for producing FluentFTP.