Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What exactly EnableThreadSafeDataConnections does? #64

Closed
nvivo opened this issue Mar 28, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@nvivo
Copy link

commented Mar 28, 2017

I'm trying to concurrently upload files using a pool of tasks and a concurrent queue. Each task has an FTP client that grabs the next file in the queue and uploads it. With EnableThreadSafeDataConnections. it seems only one file is uploaded at a time even though I'm using multiple clients. I have also tried with a single client, but had similar results. The docs say that EnableThreadSafeDataConnections will start a new connection for each file, but that doesn't seem to happen.

Can you please clarify what happens when we set EnableThreadSafeDataConnections is true or false? "Thread safe" is a very vague term.

@robinrodricks

This comment has been minimized.

Copy link
Owner

commented Mar 29, 2017

EnableThreadSafeDataConnections is an older feature built by the original author. If true, it opens a new FTP client instance (and reconnects to the server) every time you try to upload/download a file. It used to be the default setting, but it affects performance terribly so I disabled it and found many issues were solved as well as performance was restored. I believe if devs want multi-threaded uploading they should just start a new BackgroundWorker and create/use FtpClient within that thread. Try that if you want concurrent uploading, it should work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.