Skip to content
This repository has been archived by the owner on Feb 4, 2022. It is now read-only.

Update nuxt instructions in README.md #331

Merged

Conversation

FreekVR
Copy link
Contributor

@FreekVR FreekVR commented Sep 21, 2020

Adds improved examples for nuxt, including one with server-side support using cookies

What:

Updates the usage instructions to remove the deprecated ssr: false plugin option, and includes an example which will work when using Node SSR, using Cookies.

Why:

Local Storage only works client-side, so when using nuxt and server-side rendering, this will cause issues with hydrating the state from server- to client. See #293 (comment)

Checklist:

  • Documentation
  • Tests n/a
  • Ready to be merged
  • Added myself to contributors table

Adds improved examples for nuxt, including one with server-side support using cookies
Copy link
Owner

@robinvdvleuten robinvdvleuten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Couple of small requests to add a comment for less experienced Nuxt users.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@FreekVR
Copy link
Contributor Author

FreekVR commented Sep 23, 2020

Thanks for the feedback, should be a bit more clear now 👍

@robinvdvleuten
Copy link
Owner

Thank you @FreekVR!

@robinvdvleuten robinvdvleuten merged commit e8b3702 into robinvdvleuten:master Sep 24, 2020
@robinvdvleuten
Copy link
Owner

@all-contributors add @FreekVR for doc

@allcontributors
Copy link
Contributor

@robinvdvleuten

I've put up a pull request to add @FreekVR! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants