added sans-serif to font-family to display text correctly on Linux #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Firefox on Linux (Ubuntu 22.04, as of writing the most recent LTS release) the theme appeared with serif text. Investigation showed the fonts Lucida and Verdana aren't available on this machine and the default (serif) was picked. This change adds sans-serif as a last font suggestion to the font-family line.
Added sans-serif to font-family to display correctly on Linux
Added sans-serif to font-family to display correctly on Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Firefox on Linux (Ubuntu 22.04, as of writing the most recent LTS release) the theme appeared with serif text. Investigation showed the fonts Lucida and Verdana aren't available on this machine and the default (serif) was picked.
This change adds sans-serif as a last font suggestion to the font-family line.
This is my first public pull-request, so any guidance you can spare is greatly appreciated.
For example: I took the liberty to edit the minor version number in version and wcms-modules.json. Don't know if this is a good practice or an inconvenience.