Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add missing strictures #13
added a commit
this pull request
Sep 4, 2015
@ribasushi : hello! The «FATAL => 'all'» for the «use warnings;» lines exist in all other .pm source files in DBM-Deep, so I added it in the missing .pm as well for consistency. I realise it's a bad idea and avoid using it for my own code. Maybe you should file an issue for it for DBM-Deep.
@robkinyon my comment wasn't a critique of the module as a whole, just of this PR. Blindly removing FATAL's without a code audit is just as dangerous as adding them where there were none (what this PR did). To put it in terms an engineer would understand:
In any case - the original comment was simply made in passing, about something minor-ish I noticed. No action being taken is a perfectly reasonable outcome.