New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TODO tests for database transaction tests #17

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@jmaslak

jmaslak commented Jan 3, 2016

This is a simple patch to remove the failures in the transaction error tests when SQLite or MySQL is used during testing. It marks the transaction error tests as TODO tests when the engine being tested is DBI. I didn't think making them pass or removing them was the right option because it is true that the database tests actually do fail because of missing functionality in the DBI module. Because that's called out in the POD, however, I also didn't think it should fail the test suite as a whole.

I received your module as a CPAN Pull Challenge for January, and will be submitting at least one more pull request dealing with the database back end (references are not always properly removed from the database when they are overwritten - I have the fix for this but need to write tests to validate). Please feel free to give me any feedback on this or any other pull requests I submit if I can/should submit them differently.

@robkinyon

This comment has been minimized.

Show comment
Hide comment
@robkinyon

robkinyon Jan 12, 2016

Owner

Please add yourself to the contributors and update the Changes file.

Thank you so much for taking the time to work on this module. I really appreciate it.

Owner

robkinyon commented Jan 12, 2016

Please add yourself to the contributors and update the Changes file.

Thank you so much for taking the time to work on this module. I really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment