New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs with curl cmdline which follows redirects. #8

Merged
merged 1 commit into from Jul 23, 2014

Conversation

Projects
None yet
2 participants
@mithro
Contributor

mithro commented Jul 23, 2014

To improve security github has moved all user content from the github.com domain to githubuserconent.com domain, see https://developer.github.com/changes/2014-04-25-user-content-security/ for more information.

They offer redirects from the original locations, but curl won't follow redirects by default. Annoying curl doesn't error even give you an error when it hits a redirect and does nothing! Thus the command
curl https://raw.github.com/robmadole/jig-plugins/lists/common.txt > .jigplugins.txt looks like it succeeds but just ends up creating an empty .jigplugins.txt file. This confused me for a while.

Update docs with curl cmdline which follows redirects.
To improve security github has moved all user content from the github.com
domain to githubuserconent.com domain, see
https://developer.github.com/changes/2014-04-25-user-content-security/ for more
information.

They offer redirects from the original locations, but curl won't follow
redirects without the -L option.

An alternative would be to update the `https://raw.github.com/` URLs to be
`https://raw.githubusercontent.com/` instead but if they ever change the domain
again you'll need to update the documentation again.
@robmadole

This comment has been minimized.

Show comment
Hide comment
@robmadole

robmadole Jul 23, 2014

Owner

Wow I didn't realize it was creating empty .jigplugins.txt files! Thanks for fixing this. I'll merge it now and cut a release here in a few minutes.

Owner

robmadole commented Jul 23, 2014

Wow I didn't realize it was creating empty .jigplugins.txt files! Thanks for fixing this. I'll merge it now and cut a release here in a few minutes.

robmadole added a commit that referenced this pull request Jul 23, 2014

Merge pull request #8 from mithro/develop
Update docs with curl cmdline which follows redirects.

@robmadole robmadole merged commit c6fa9e9 into robmadole:develop Jul 23, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment