Update docs with curl cmdline which follows redirects.#8
Merged
robmadole merged 1 commit intorobmadole:developfrom Jul 23, 2014
Merged
Update docs with curl cmdline which follows redirects.#8robmadole merged 1 commit intorobmadole:developfrom
robmadole merged 1 commit intorobmadole:developfrom
Conversation
To improve security github has moved all user content from the github.com domain to githubuserconent.com domain, see https://developer.github.com/changes/2014-04-25-user-content-security/ for more information. They offer redirects from the original locations, but curl won't follow redirects without the -L option. An alternative would be to update the `https://raw.github.com/` URLs to be `https://raw.githubusercontent.com/` instead but if they ever change the domain again you'll need to update the documentation again.
Owner
|
Wow I didn't realize it was creating empty .jigplugins.txt files! Thanks for fixing this. I'll merge it now and cut a release here in a few minutes. |
robmadole
added a commit
that referenced
this pull request
Jul 23, 2014
Update docs with curl cmdline which follows redirects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To improve security github has moved all user content from the github.com domain to githubuserconent.com domain, see https://developer.github.com/changes/2014-04-25-user-content-security/ for more information.
They offer redirects from the original locations, but curl won't follow redirects by default. Annoying
curldoesn't error even give you an error when it hits a redirect and does nothing! Thus the commandcurl https://raw.github.com/robmadole/jig-plugins/lists/common.txt > .jigplugins.txtlooks like it succeeds but just ends up creating an empty .jigplugins.txt file. This confused me for a while.