Dataset merge #158
Merged
Dataset merge #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SkalskiP Please try to fix if needed. I will check them tomorrow. |
|
@hardikdava I'll take a look in 30 min |
SkalskiP
approved these changes
Jun 28, 2023
|
@hardikdava I did a review and minor refactoring and added many unit tests. I'll test if it works on a few examples now. |
|
@hardikdava Tested! It looks like it works! 🔥 Merging! |
|
@hardikdava wanna contribute anything more? or taking a break? :D |
|
@SkalskiP I can keep continue contributing but i can spend a bit low time. Let me know what you have in mind for further ? |
SkalskiP
added
enhancement
|
@hardikdava, how about this: #160? This should be simple to implement. |
|
@SkalskiP do we any API for this feature or I have to create a new one? This will not take much time. You can assign it to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue: #155
Type of change
Please delete options that are not relevant.
Any specific deployment considerations
Docs