Skip to content

Conversation

@hardikdava
Copy link
Contributor

Description

This PR is in support for #187

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

Find colab here

Docs

  • Docs updated? What were the changes:

@SkalskiP SkalskiP added the version: 0.13.0 Feature to be added in `0.13.0` release label Jul 18, 2023
@SkalskiP SkalskiP added this to the version: 0.13.0 milestone Jul 18, 2023
@SkalskiP
Copy link
Collaborator

@hardikdava, do you want to ship it in this release?

@hardikdava
Copy link
Contributor Author

@SkalskiP yeah, we can include it.

@SkalskiP
Copy link
Collaborator

@hardikdava, do you have some Colab I could use to test it?

@SkalskiP SkalskiP marked this pull request as ready for review July 21, 2023 09:27
@hardikdava
Copy link
Contributor Author

@hardikdava, do you have some Colab I could use to test it?

Here you go.

@SkalskiP
Copy link
Collaborator

Here

I don't have access :/

@hardikdava
Copy link
Contributor Author

Here

I don't have access :/

Check now please.

@SkalskiP
Copy link
Collaborator

@hardikdava I'm unsure if I'm doing something wrong, but the Colab fails. I get an exception.

Screenshot 2023-07-21 at 12 17 11

@hardikdava
Copy link
Contributor Author

Yeah, I am also getting same error. But it was working fine 😆

@SkalskiP
Copy link
Collaborator

@hardikdava would you have a bit of time to take a look at it?

@hardikdava
Copy link
Contributor Author

@SkalskiP Yeah, i will let you know once I fix it.

@hardikdava
Copy link
Contributor Author

@SkalskiP I tried various installation but I could not do it. Let's keep this on next release.

@SkalskiP
Copy link
Collaborator

@hardikdava, no worries! 🙏🏻 I plan to close 0.12.0 release on Monday. I'm happy to move this one to 0.13.0 and have our full focus on things we can still close.

@hardikdava
Copy link
Contributor Author

hello @SkalskiP , I fixed the colab test. Please test it with update colab: https://colab.research.google.com/drive/1R8mLUFsoflwTK4PSfnOXmKtw7Keu2zlX?usp=sharing

@SkalskiP
Copy link
Collaborator

@hardikdava I'm still trying to figure out what's going on, but I still doesn't work for me.

Screenshot 2023-07-22 at 17 30 34

@onuralpszr
Copy link
Contributor

@hardikdava I'm still trying to figure out what's going on, but I still doesn't work for me.

Screenshot 2023-07-22 at 17 30 34

Let me take tackle this a little bit I think I have an idea......

@hardikdava
Copy link
Contributor Author

@onuralpszr thanks. I like how we are helping each other with bugs and errors.

@onuralpszr
Copy link
Contributor

@hardikdava @SkalskiP hurray :))

image

@onuralpszr
Copy link
Contributor

Do this commands then re-import again

!wget http://nz2.archive.ubuntu.com/ubuntu/pool/main/o/openssl/libssl1.1_1.1.1f-1ubuntu2.19_amd64.deb
!sudo dpkg -i libssl1.1_1.1.1f-1ubuntu2.19_amd64.deb

@SkalskiP SkalskiP changed the base branch from main to develop July 23, 2023 19:11
@SkalskiP
Copy link
Collaborator

@hardikdava am I correct to assume we are ready to merge here?

@onuralpszr
Copy link
Contributor

@hardikdava am I correct to assume we are ready to merge here?

Also, Did you able to run with my fix ?

@hardikdava
Copy link
Contributor Author

@hardikdava am I correct to assume we are ready to merge here?

Also, Did you able to run with my fix ?

Thanks @onuralpszr. yeah, I was able to run it.

@SkalskiP
Copy link
Collaborator

Hi @hardikdava! 👋🏻 Just tested your Colab. Looks good. Merging! 🔥

@SkalskiP SkalskiP merged commit 27e8e2d into roboflow:develop Jul 28, 2023
@hardikdava
Copy link
Contributor Author

``

Hi @hardikdava! 👋🏻 Just tested your Colab. Looks good. Merging! 🔥

Great 🚀 @SkalskiP .

@hardikdava hardikdava deleted the paddledet_support branch August 10, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version: 0.13.0 Feature to be added in `0.13.0` release

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants