-
Notifications
You must be signed in to change notification settings - Fork 2k
Image Path as keys for DetectionDataset #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@SkalskiP This is an initial PR is for lazy dataset loading and integration for yoloexplorer. |
@capjamesg Please check it out if anything changes for |
@SkalskiP can we quickly merge this? Then we are good to go for |
@hardikdava merge it or release it? :) Because the release will probably come in 1-2 weeks. But merge can be today. |
@SkalskiP let's merge it for now. I will make changes accordingly for initial integration. |
@hardikdava, we cant merge it. You made changes only in |
@SkalskiP noted. |
@hardikdava let me know when you'll have a version ready for tests 🙏🏻 |
Hey 👋 @SkalskiP , I have changed the required method. Let me know I have missed anything else. |
Hi, @hardikdava 👋🏻 do you maybe have some colab I could use for testing? |
Hi @hardikdava 👋🏻 I'm testing it now. |
Here is my colab I used for testing: https://colab.research.google.com/drive/1OstGePg0mKfe6tZr6dxAj2b4oBhlm657?usp=sharing |
Hi @hardikdava 👋🏻! Merging. |
Description
sv.DetectionDatasets
is usingimage_name
as keys forDict
. This can be leading to create issues like same there can be possibility of having same name in multiple dataset. Also, savingimage_path
can be useful for not loading the whole image dataset but only load when necessary.This PR is only redesigning the existing code.