Repository navigation
Add timm data loader for sv.Classifications - #572
Merged
Merged
Conversation
Collaborator
|
@capjamesg, is that PR ready for review? I see it is still marked as btw, just want to remind you about: |
capjamesg
marked this pull request as ready for review
November 27, 2023 10:51
Collaborator
|
@capjamesg pre-commit is failing can you fix this? |
Contributor
Author
|
@SkalskiP Here is a Colab for this PR: https://colab.research.google.com/drive/1eHmk_5GgdqI2wGj08UZbQ0peNTKVG4b2?usp=sharing |
The variable names and usage within the 'ultralytics' and 'timm' functions were updated for improved code readability. The docstrings were also refined to better explain the function parameters. Instances where YOLO was redundantly called were also eliminated.
Adjustments have been made to the import statements in the 'core.py' file of the 'classification' module.
SkalskiP
approved these changes
Nov 27, 2023
Collaborator
|
Awesome! Thanks a lot, @capjamesg! 馃檹馃徎 Merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a data loader for classifications from the
timmPython package.Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
You can test the API using the following code:
Any specific deployment considerations
N/A
Docs
This PR does not yet contain a docs update, but I will add documentation for the method as part of this PR.