Permalink
Browse files

check for blocked popups onload. #52

  • Loading branch information...
1 parent ce1967d commit a749c467abe5ecd89a2305da098558226529ee61 @paulirish paulirish committed Sep 24, 2012
Showing with 6 additions and 4 deletions.
  1. +1 −1 app.yaml
  2. +5 −3 static/robohornet.js
View
@@ -1,5 +1,5 @@
application: robohornet-benchmark
-version: 1
+version: 2
runtime: python27
api_version: 1
threadsafe: true
View
@@ -356,8 +356,10 @@ robohornet.Runner = function(data) {
',width='+ TARGET_WINDOW_WIDTH + ',height=' + TARGET_WINDOW_HEIGHT);
if (this.benchmarkWindow_) {
- if (this.benchmarkWindow_.innerHeight <= 0)
- this.onPopupBlock_();
+ this.benchmarkWindow_.onload = function(){
+ if (this.benchmarkWindow_.innerHeight <= 0)
+ this.onPopupBlock_();
+ };
} else {
this.onPopupBlock_();
}
@@ -366,7 +368,7 @@ robohornet.Runner = function(data) {
_p.onPopupBlock_ = function() {
// Reclaim window's name so we can use it again
- //this.benchmarkWindow_ && this.benchmarkWindow_.close();
+ this.benchmarkWindow_ && this.benchmarkWindow_.close();
this.setBenchmarkStatus_(this.activeBenchmark_, robohornet.enabledBenchmarks.POPUP_BLOCKED);
this.activeBenchmark_ = null;

0 comments on commit a749c46

Please sign in to comment.