Validate intents passed to start/stop/bindService. #5053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-robolectric
force-pushed
the
piper_249154095
branch
from
ee6c619
to
99f4642
Compare
The Android OS normally throws an IllegalArgumentException if an implicit Intent is passed to one of these methods by an app which targets SDK 21 or higher. However, this logic was lost because Robolectric shadows these methods, and only the actual implementation has access to the private Intent validation method. Copy the relatively simple validation check into Robolectric to achieve the same behavior. Existing usage of these methods in tests must be updated to use explicit intents rather than implicit ones in order for those tests not to crash. Prod code should also be audited to ensure that these methods are never called with implicit intents (at least on SDK 21+). See #5016 PiperOrigin-RevId: 250337437
copybara-robolectric
force-pushed
the
piper_249154095
branch
from
99f4642
to
21375be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate intents passed to start/stop/bindService.
The Android OS normally throws an IllegalArgumentException if an
implicit Intent is passed to one of these methods by an app which
targets SDK 21 or higher. However, this logic was lost because
Robolectric shadows these methods, and only the actual implementation
has access to the private Intent validation method. Copy the
relatively simple validation check into Robolectric to achieve the
same behavior.
Existing usage of these methods in tests must be updated to use
explicit intents rather than implicit ones in order for those tests
not to crash. Prod code should also be audited to ensure that these
methods are never called with implicit intents (at least on SDK 21+).