Allow updating history in WebView async. #5654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-robolectric
force-pushed
the
piper_311727608
branch
5 times, most recently
from
7c9faa0
to
882279f
Compare
copybara-robolectric
force-pushed
the
piper_311727608
branch
from
882279f
to
2920890
Compare
WebView does not update its history inline when loadUrl() is called. It starts a "navigation" which might or might not "commit" (i.e. decide to show something to the user). For example, a gen204 request never commits, calling loadUrl() with such a request would never "commit" to the history. Or two loadUrl() calls can be made immediately after one another, in which case the first is never committed as it is dropped. This commit always happens async and never inline. As such, ShadowWebView behaviour is inconsistent with the prod behaviour. Introducing pushEntryToHistory() API allows this commit to be performed asynchronously when requested. This API also takes a URL, which does not have to be the same as the one in loadUrl() as there might have been e.g. server-side redirects until the page is committed. Though if the URL does not go through any changes the caller can also perform pushEntryToHistory(webView.getUrl()). This API can also be used without an associated loadUrl() call to simulate a renderer-initiated navigation, such as when the user-clicks on a link. PiperOrigin-RevId: 311727608
copybara-robolectric
force-pushed
the
piper_311727608
branch
from
2920890
to
9703400
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow updating history in WebView async.
WebView does not update its history inline when loadUrl() is called. It goes into a "navigation" which can be dropped or "committed". When a navigation is "committed" it is then pushed into the history.
We cannot just change this behaviour directly as that would break a lot of existing tests. Instead we allow simulating the async behaviour with a boolean flag. This should not change anything semantically unless opted-in.