Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support overriding Icon loading executor from Icon#loadDrawableAsync. #6828

Merged
merged 1 commit into from Nov 17, 2021

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Nov 5, 2021

Support overriding Icon loading executor from Icon#loadDrawableAsync.

Icon#loadDrawableAsync is loading icon on AsyncTask#THREAD_POOL_EXECUTOR, that test has no way to control the execution. This patch adds a dedicated executor overriding as ShadowIcon#setIconAsyncLoadingExecutor to let test control where the async icon loading will happen.

Icon#loadDrawableAsync is loading icon on AsyncTask#THREAD_POOL_EXECUTOR, that test has no way to control the execution. This patch adds a dedicated executor overriding as ShadowIcon#overrideExecutor to let test control where the async icon loading will happen.

PiperOrigin-RevId: 407821420
@hoisie hoisie merged commit 8d88144 into master Nov 17, 2021
13 checks passed
@hoisie hoisie deleted the piper_407821420 branch Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant