Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solution log for unhandled PNG file #6829

Merged

Conversation

utzcoz
Copy link
Member

@utzcoz utzcoz commented Nov 7, 2021

Close #6812.

I don't have related images without copyright problem for this change, so I tested it with demo at #6812. It will print a log for unhandled PNG file with link #6812. The developer can get potential solution from this issue's discussion.

@utzcoz
Copy link
Member Author

@utzcoz utzcoz commented Nov 7, 2021

com.example.myapplication.ExampleUnitTest > decode_png STANDARD_ERROR
Looks like your PNG file has format problem that OpenJDK can't process correctly. You can check #6812 for potential solution.

This is printed log at terminal.

@utzcoz
Copy link
Member Author

@utzcoz utzcoz commented Nov 7, 2021

Hi @ganadist , it's nice if you help to take look at it, and check it with your demo.

@utzcoz utzcoz requested a review from hoisie Nov 7, 2021
@utzcoz
Copy link
Member Author

@utzcoz utzcoz commented Nov 7, 2021

The new print log is here:

com.example.myapplication.ExampleUnitTest > decode_png STANDARD_ERROR
Looks like your PNG file(/tmp/test3261116438509710556image) has format problem that OpenJDK can't process correctly. You can check #6812 for potential solution.

@utzcoz
Copy link
Member Author

@utzcoz utzcoz commented Nov 7, 2021

Hope this PR can get enough testing.

@utzcoz
Copy link
Member Author

@utzcoz utzcoz commented Nov 8, 2021

The testing is here #6812 (comment).

@utzcoz
Copy link
Member Author

@utzcoz utzcoz commented Nov 16, 2021

Hi @hoisie , could you help to review this PR again? Thanks.

utzcoz added 4 commits Nov 17, 2021
Signed-off-by: utzcoz <utzcoz@outlook.com>
Signed-off-by: utzcoz <utzcoz@outlook.com>
…gth"

Signed-off-by: utzcoz <utzcoz@outlook.com>
@utzcoz utzcoz force-pushed the add-solution-log-for-unhandled-PNG-file branch from 50249f2 to 2d3729e Compare Nov 17, 2021
@hoisie hoisie merged commit ddccf11 into robolectric:master Nov 22, 2021
13 checks passed
@utzcoz utzcoz deleted the add-solution-log-for-unhandled-PNG-file branch Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants