Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow Build.VERSION#MEDIA_PERFORMANCE_CLASS #6836

Merged
merged 1 commit into from Nov 17, 2021
Merged

Shadow Build.VERSION#MEDIA_PERFORMANCE_CLASS #6836

merged 1 commit into from Nov 17, 2021

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Nov 9, 2021

Shadow Build.VERSION#MEDIA_PERFORMANCE_CLASS

Performance class was added in Android S.
See https://developer.android.com/topic/performance/performance-class

@utzcoz
Copy link
Member

@utzcoz utzcoz commented Nov 10, 2021

Hi @hoisie, looks like this PR has changes that removing support v4 shadows. Is it better to remove it at 4.8 release?

@copybara-service copybara-service bot force-pushed the piper_408717180 branch 2 times, most recently from 947d123 to 990d274 Compare Nov 10, 2021
Performance class was added in Android S.
See https://developer.android.com/topic/performance/performance-class

PiperOrigin-RevId: 408717180
@hoisie
Copy link
Contributor

@hoisie hoisie commented Nov 17, 2021

@utzcoz that was unintentional, sorry for the confusion. We were doing some work at Google to prepare for removing the support library shadows in Robolectric, and for some reason that confused Copybara.

@hoisie hoisie merged commit 92174b5 into master Nov 17, 2021
13 checks passed
@hoisie hoisie deleted the piper_408717180 branch Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants