Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove instrumentedPackages workaround #6875

Merged
merged 1 commit into from Nov 22, 2021
Merged

Conversation

hoisie
Copy link
Contributor

@hoisie hoisie commented Nov 21, 2021

No description provided.

@utzcoz
Copy link
Member

@utzcoz utzcoz commented Nov 21, 2021

Looks like I am confused by release content of androidx.test before. Every release is tagged with name androidx-test-*, but its release is bound with multiple libraries, including Espresso. The stable release of androidx.test will contain Espresso name at its release name, likes "AndroidX Test 1.4.0/Espresso 3.4.0"(https://github.com/android/android-test/releases/tag/androidx-test-1.4.0). But latest alpha release doesn't contains it, likes "AndroidX Test Sept 28 2021"(https://github.com/android/android-test/releases/tag/androidx-test-09_28_2021). Does it mean there is no Espresso updates? When I said related PR was merged in specific androidx.test release tag, and this version and later version will fix this problem. But other users may think I am saying androidx.test core related libraries.

@brettchabot
Copy link
Contributor

@brettchabot brettchabot commented Nov 21, 2021

Looks like I am confused by release content of androidx.test before. Every release is tagged with name androidx-test-*, but its release is bound with multiple libraries, including Espresso. The stable release of androidx.test will contain Espresso name at its release name, likes "AndroidX Test 1.4.0/Espresso 3.4.0"(https://github.com/android/android-test/releases/tag/androidx-test-1.4.0). But latest alpha release doesn't contains it, likes "AndroidX Test Sept 28 2021"(https://github.com/android/android-test/releases/tag/androidx-test-09_28_2021). Does it mean there is no Espresso updates? When I said related PR was merged in specific androidx.test release tag, and this version and later version will fix this problem. But other users may think I am saying androidx.test core related libraries.

Sorry for confusion.

You are correct that historically typically we released all the androidx.test libraries that are managed in android-test github all at once under a title like AndroidX Test 1.4.0/Espresso 3.4.0. But we received complaints about that practice.

Going forward each androidx.test library may be released independently, so we haven't been using github releases to document and tag them the last couple of releases. Eg the last release only included monitor, services and orchestrator. Instead the changes have only been documented at https://developer.android.com/jetpack/androidx/versions
I should add documentation to the github project to make that clear.

This is fixed by updating espresso to 3.5.0-alpha03.

cc robolectric#6593
@hoisie hoisie requested a review from utzcoz Nov 22, 2021
utzcoz
utzcoz approved these changes Nov 22, 2021
@utzcoz
Copy link
Member

@utzcoz utzcoz commented Nov 22, 2021

I should add documentation to the github project to make that clear.

Thanks for explaining it. If there is a section on GitHub README.md, users can get more knowledge about how to select androidx.test dependencies.

BTW, there is another thing about androidx.test doc: https://android.github.io/android-test/contribute/index.html is too old. I don't find where is the doc source code, so I don't send PR to update it. If need, I can fire an issue at androidx.test repository.

@hoisie hoisie merged commit 81b9538 into robolectric:master Nov 22, 2021
14 checks passed
@hoisie hoisie deleted the android-x-issue branch Nov 22, 2021
hoisie added a commit to hoisie/robolectric that referenced this issue Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants