Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid re-running ICU ./configure if Makefile exists #6889

Merged
merged 2 commits into from Nov 29, 2021

Conversation

hoisie
Copy link
Contributor

@hoisie hoisie commented Nov 29, 2021

This makes running ./gradlew :nativeruntime:processResources much,
much faster after ICU has been built.

@hoisie hoisie requested a review from utzcoz Nov 29, 2021
utzcoz
utzcoz approved these changes Nov 29, 2021
nativeruntime/build.gradle Show resolved Hide resolved
nativeruntime/build.gradle Outdated Show resolved Hide resolved
utzcoz
utzcoz approved these changes Nov 29, 2021
@utzcoz
Copy link
Member

@utzcoz utzcoz commented Nov 29, 2021

Looks like "validate gradle wrapper" action timeout. It is not a problem. We can omit it for this PR.

hoisie added 2 commits Nov 29, 2021
Unnecessarily re-running ICU configure is costly -- it takes around
10-20s by itself, and it also invalidates some build artifacts, which
results in 'make' having to do work.

This makes running `./gradlew :nativeruntime:processResources` much,
much faster (18s -> 2.5s on my machine) after ICU has been built.

Also, improve the error message when ICU configure is run on an
unsupported OS.
Previously, the logic to handle SKIP_NATIVERUNTIME_BUILD in
processResources was in a Gradle 'onlyIf' block, which meant that the
'makeNativeRuntime' task still ran.

Update the nativeruntie processResources task to also skip running
`makeNativeRuntime` if SKIP_NATIVERUNTIME_BUILD is set to true.
@hoisie hoisie merged commit e4cb2f1 into robolectric:master Nov 29, 2021
14 checks passed
@hoisie hoisie deleted the skip-configure branch Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants