Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip to generate shadowOf for ShadowBackdropFrameRenderer #7284

Conversation

utzcoz
Copy link
Member

@utzcoz utzcoz commented Apr 30, 2022

The BackdropFrameRenderer is private/hidden/internal API, and we don't need to generate shadowOf for this class.

The BackdropFrameRenderer is private/hidden/internal API, and we don't
need to generate shadowOf for this class.

Signed-off-by: utzcoz <utzcoz@outlook.com>
@utzcoz
Copy link
Member Author

@utzcoz utzcoz commented Apr 30, 2022

When I tried to upgrade Robolectric 4.8 for Flutter at PR flutter/engine#33024, tests of Flutter failed when it uses shadowOf because BackdropFrameRenderer is not found. The BackdropFrameRenderer is an internal API, and we don't need to generate shadowOf for it. It will cause class not found when test module's minSdk is less than 24(? This class is added from 2015.11, and API 24 is release at 2016). I have generated 4.9-SNAPSHOT locally and test it with Flutter, the previous class not found problem disappeared.

@utzcoz utzcoz requested a review from hoisie Apr 30, 2022
hoisie
hoisie approved these changes Apr 30, 2022
@utzcoz utzcoz merged commit 7561451 into robolectric:master May 1, 2022
16 checks passed
@utzcoz utzcoz deleted the remove-shadowOf-of-ShadowBackdropFrameRenderer branch May 1, 2022
@utzcoz
Copy link
Member Author

@utzcoz utzcoz commented May 2, 2022

Hi @hoisie @JuliaSullivanGoogle , will we have a 4.8.1 release with this commit at this week? cc @ganadist

@hoisie
Copy link
Contributor

@hoisie hoisie commented May 2, 2022

Yeah definitely I will start the process ASAP

@hoisie
Copy link
Contributor

@hoisie hoisie commented May 3, 2022

4.8.1 is out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants