Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release version is not "templatizable" #669

Closed
sgandon opened this issue Jun 10, 2019 · 0 comments · Fixed by #671
Closed

release version is not "templatizable" #669

sgandon opened this issue Jun 10, 2019 · 0 comments · Fixed by #671

Comments

@sgandon
Copy link
Contributor

sgandon commented Jun 10, 2019

in the release definition many element can be set as templates like chart, namespace, name... but not the chart version.
see

helmfile/pkg/state/release.go

Line 9 in 3710f62

func (r ReleaseSpec) ExecuteTemplateExpressions(renderer *tmpl.FileRenderer) (*ReleaseSpec, error) {

This would be very usefull if the version is to maintained in some values file.
@sgandon sgandon mentioned this issue Jun 10, 2019
Merged
mumoshu pushed a commit that referenced this issue Jun 11, 2019
@sgandon @mumoshu
feat: make release version templatized (#671)
11eda66 
Allows the release version to be a Go template.
Resolves #669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: make release version templatized sgandon/helmfile
1 participant
@sgandon