Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

40% sampling speed improvement by avoiding time check on every byte in waitPoint(...) #7

Open
wants to merge 1 commit into
base: master
from

Conversation

@avirtuos
Copy link

@avirtuos avirtuos commented Jul 9, 2016

  • 40% sampling speed improvement by avoiding time check on every byte in waitPoint(...)
  • Migrated to SoftSerial from HardwareSerial
  • Tested on Arduino Leonardo and Pro Micro with RPLidar 360
- 40% sampling speed improvement by avoiding time check on every byte in waitPoint(...)
- Tested on Arduino Leonardo and Pro Micro with RPLidar 360
@avirtuos avirtuos changed the title - 40% sampling speed improvement by avoiding time check on every byte in waitPoint(...) 40% sampling speed improvement by avoiding time check on every byte in waitPoint(...) Jul 9, 2016
@avirtuos
Copy link
Author

@avirtuos avirtuos commented Jul 22, 2016

Any updates on this request? I'm sure your customers would appreciate the significant performance improvement. If it helps I can separate the SoftSerial changes from the 3-line performance improvement change. Please let me know. Thanks.

@avirtuos
Copy link
Author

@avirtuos avirtuos commented Feb 17, 2017

Almost 1 year and still no answer on this. I've called your company's support number and emailed the support address. I can officially say I won't be buying any future products made by your company considering the level of support your drivers clearly receive.

@Titibo26
Copy link

@Titibo26 Titibo26 commented May 21, 2019

Seems to work fine on ESP32. It's so disappointing that slamtec doesn't support this anymore...

@wesamjabali
Copy link

@wesamjabali wesamjabali commented Dec 19, 2020

This is important. I'm going to use this instead of the original driver.

@avirtuos
Copy link
Author

@avirtuos avirtuos commented Dec 19, 2020

You are likely to get better support from me than SlamTech anyway lol

@wesamjabali
Copy link

@wesamjabali wesamjabali commented Dec 20, 2020

Well, I'm actually totally not getting a response on my lidar.waitPoint() on either of them. The motor control works, but the lidar isn't giving me any data on either hardware or software serial. Any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants