fix StringIO import as it was removed in robot 5.0
#1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assuming the failed CI has nothing to do with my change because the same is happening on every other open PR |
|
It's not, this is caused by a bug in ApprovalTests.Python. |
|
Ping @emanlove and @rasjani Approval test is causing problems, because of: approvals/ApprovalTests.Python#103 Pinning the Approval test version should fix the problem. |
|
Just an update, in adding robotframework version 5.0.1 the acceptance tests were having some strange issues. Investigated those last weekend with no resolution and ran out of time. Going to pick this back up again. Either way this changes looks needed so I am going ahead and merge it in. This may break tests for a bit. |
emanlove
added
deprecation
priority: low
and removed
acknowledge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1752