Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Register browser even if get url fails. #263

Merged
merged 4 commits into from Jan 24, 2014

Conversation

Projects
None yet
2 participants
Contributor

emanlove commented Jan 9, 2014

Test and patch for fixing issue rtomac/robotframework-selenium2library#70.

emanlove added some commits Jan 2, 2014

@emanlove emanlove Register browser even if get url fails.
An issue was reported with SeleniumLibrary [1] where if "Open Browser"
succeeds in starting the browser but the get url call fails the opened
browser doesn't get registered with the Library's internal browser registery.
Thus when 'Close All Browsers' is called it fails to close the opened browser.
This patch fixes that problem.

[1] http://code.google.com/p/robotframework-seleniumlibrary/issues/detail?id=220
7ad56e9
@emanlove emanlove Added debug log message indicating failed to open url. c7769a8
@emanlove emanlove Added test verifying browser closes if 'Open Browser' is incomplete.
This patch verifies the fix for #70.
21829ec
@emanlove emanlove Merge branch 'close-browser-on-failed-open' 9e16282
Contributor

ombre42 commented Jan 24, 2014

Looks good to me

@ombre42 ombre42 added a commit that referenced this pull request Jan 24, 2014

@ombre42 ombre42 Merge pull request #263 from emanlove/master
Register browser even if get url fails.
bad7fa8

@ombre42 ombre42 merged commit bad7fa8 into robotframework:master Jan 24, 2014

1 check failed

default The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment