Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialogs: New Get Selections From User to allow selecting multiple values #2906

Closed
rfabbris opened this issue Jul 20, 2018 · 4 comments
Closed
Labels
acknowledge To be acknowledged in release notes enhancement good first issue Good for newcomers help wanted Extra help appreciated priority: medium rc 1
Milestone

Comments

@rfabbris
Copy link

In Dialogs library, nowadays there is only the possibility to choose one selection through a dropdown list (see Get Selection From User).
It would be really helpful to have a keyword to display tick boxes and to give the possibility to choose multiple selections.
The input could be a list with the possible selections (e.g. ${fruits} = Create List apple banana)
The output could be either a list with the chosen options or a dictionary with all the possibilities and the information of which one of them has been chosen (e.g. ${fruits_chosen} = Get Selections From User ${fruits})

@pekkaklarck
Copy link
Member

Sounds good to me. I think inputs should be same as to Get Selection From User. Return value probably should be a list of selected values. Anyone interested to implement this?

@marq35
Copy link

marq35 commented Jul 24, 2018

You can assign me to this issue :)

@pekkaklarck
Copy link
Member

We got a PR so let's try to get this into 3.1.

@pekkaklarck pekkaklarck added this to the v3.1 milestone Oct 25, 2018
@pekkaklarck pekkaklarck added the acknowledge To be acknowledged in release notes label Nov 7, 2018
@pekkaklarck
Copy link
Member

Thanks to PR #2987 by @cristii006 this is now implemented and will be included in RF 3.1 beta 2 (or rc 1, whichever the next release is).

@pekkaklarck pekkaklarck changed the title Add a new keyword like Get Selections From User Dialogs: New Get Selections From User to allow selecting multiple values Nov 7, 2018
pekkaklarck added a commit that referenced this issue Nov 7, 2018
pekkaklarck added a commit that referenced this issue Nov 8, 2018
- "Get Selection(s) From User" now support multiline text. Fixes #3003.
- "Get Selections From User" shows 8 entries, not only 4. See #2906 and
  PR #2987.
- "Get Selection(s) From User" have better layout manager. Required
  to support longer messages and more than 4 entries (see above) without
  totally breaking the layout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge To be acknowledged in release notes enhancement good first issue Good for newcomers help wanted Extra help appreciated priority: medium rc 1
Projects
None yet
Development

No branches or pull requests

3 participants