Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/video #3

Merged
merged 3 commits into from Nov 28, 2017
Merged

Feature/video #3

merged 3 commits into from Nov 28, 2017

Conversation

@m3d
Copy link
Member

@m3d m3d commented Nov 27, 2017

Record video in separate VIDEO_STREAM. LogWriter has to have locks now (but time is recorded before lock acquisition*) and the video data (from simulator) are packed by zlib. Traveling 1m with recording without video was 158kB, with uncompressed video 4.2MB and with zlib packed video 2.2MB. This packing could/should be feature of the logger, maybe - but then there need for some flags per stream ... not this project, maybe "later".

Any comments?

p.s. there were actually only 3 images in that 1m navigation ... and I did not try to visualize them yet

(*) this is maybe mistake, because then the order of stored messages does not guarantee order by time - I will add fixup

@m3d m3d requested a review from zwn Nov 27, 2017
@m3d m3d force-pushed the feature/video branch from 9e25b1c to 598555a Nov 28, 2017
@m3d m3d merged commit 2532a80 into master Nov 28, 2017
@m3d m3d deleted the feature/video branch Nov 28, 2017
@zwn
Copy link
Member

@zwn zwn commented Nov 28, 2017

The idiom you are looking for is iterator + for loop 😉 - I tried to add the comment to the specific line but github will not let me 😟 . It concerns this code:

        while True:
            try:
                data = log.read(VIDEO_STREAM)[2]
            except LogEnd:
                break

It is usually written like this:

        for _, _, data in log.read(VIDEO_STREAM):
                pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.