New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lidarview - draw scale and use +/- for zooming #132

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
2 participants
@m3d
Copy link
Member

m3d commented Jan 27, 2019

This is a small pull-request for drawing scale & user zoom in/out

@m3d m3d requested a review from zwn Jan 27, 2019

@m3d

This comment has been minimized.

Copy link
Member Author

m3d commented Jan 29, 2019

OK, in meantime I added also optional drawing poses.

@m3d

This comment has been minimized.

Copy link
Member Author

m3d commented Jan 30, 2019

lidarview-eduro-basement

motivation picture ...

@m3d m3d added the SubT label Jan 30, 2019

@zwn
Copy link
Member

zwn left a comment

Not much to add this time 😄

only_stream = [lidar_id, poses_id]
if camera_name is not None:
camera_id = names.index(camera_name) + 1
only_stream.append(camera_id)

This comment has been minimized.

@zwn

zwn Jan 30, 2019

Member

It is just a small nit, but this if-else part could probably be improved. It is not immediately obvious which combination of inputs is supported. It seems that it is not possible to include camera_name if pose_name is None, right? Can we have two separate ifs that independently append to only_stream it the name is set?

only_stream = [ lookup_stream_id(logfile, lidar_name) ]
if poses_name is not None:
  only_stream.append( lookup_stream_id(logfile, poses_name) )
if camera_name is not None:
  only_stream.append( lookup_stream_id(logfile, camera_name) )

?

This comment has been minimized.

@m3d

m3d Jan 30, 2019

Author Member

Thanks - I was not happy with this section too. I plan to make all inputs optional and sampling given by lidar, camera, poses in this order. If none is specified then it should list all names.

@zwn
Copy link
Member

zwn left a comment

👍

Extend osgar.tools.lidarview functionality
- draw scale and use +/- for zooming
- draw LIDAR position
- add optional pose2d stream id and draw robot orientation
- draw poses tail
- add option to draw image stream
  - use key 'c' to switch camera on/off
- make all streams optional

@m3d m3d force-pushed the feature/lidarview-zoom branch from b1a81a4 to aee1ea2 Jan 31, 2019

@m3d m3d merged commit 06cf32a into master Jan 31, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@m3d m3d deleted the feature/lidarview-zoom branch Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment