New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenCV driver for camera logging #134

Merged
merged 1 commit into from Feb 5, 2019

Conversation

Projects
None yet
2 participants
@m3d
Copy link
Member

m3d commented Jan 31, 2019

This is primarily driver for camera Robik.

Note, that I did not add it into "all_drivers" because of dependency on OpenCV.

@m3d m3d added the SubT label Jan 31, 2019

@m3d m3d requested a review from zwn Jan 31, 2019

@zwn
Copy link
Member

zwn left a comment

Not much to add. You can add it to drivers if the import is guarded by try-catch. That way if cv2 is not available, the driver will not be available as well and vice versa. But I am not sure if it is worth it.

@m3d m3d force-pushed the feature/opencv-driver branch from d240a53 to 7ce9600 Feb 5, 2019

@m3d m3d merged commit 07f5d10 into master Feb 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@m3d m3d deleted the feature/opencv-driver branch Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment