Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/strip #237

Open
wants to merge 5 commits into
base: master
from

Conversation

@m3d
Copy link
Member

commented Sep 1, 2019

tool to strip down debug streams from large logfiles - primary usage is virtual SubT and removal of ROS TCP communication)

m3d added 2 commits Sep 1, 2019
logger.py - add option to force external time stamp
- add optional parameter with external time stamp
- allow external start_time and filename

@m3d m3d requested a review from zwn Sep 1, 2019

osgar/logger.py Outdated Show resolved Hide resolved
osgar/tools/strip.py Outdated Show resolved Hide resolved
osgar/tools/strip.py Show resolved Hide resolved
@m3d

This comment has been minimized.

Copy link
Member Author

commented Sep 2, 2019

well, I am not quite happy about the intermediate version, but ...
reason:

  1. what to do if you fill both?
  2. you can keep also by ID (numbers), but remove only by names
    (and maybe also something I overlooked)
    and as I wrote, the use case is probably slightly different ("all in/out for app" for example)
@zwn

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

1. what to do if you fill both?

error out?

@zwn
zwn approved these changes Sep 12, 2019
@zwn

This comment has been minimized.

Copy link
Member

commented Sep 19, 2019

Can we please merge this? I'd like to use the changes in LogWriter to implement a simple benchmark to help with #204 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.