New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add driver for Timer with integration test #83

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@m3d
Member

m3d commented Sep 21, 2018

This is an alternative mentioned in #81 to trigger (potentially "synchronously") some data collection tasks and to avoid time.sleep() calls in the implementation of modules. If this is the preferred way then I would first merge this PR and rebase #81 on it.

@m3d m3d requested a review from zwn Sep 21, 2018

@m3d

This comment has been minimized.

Member

m3d commented Oct 17, 2018

This PR can wait a bit more, as it was not tested in real setup ... it was just an idea, how to avoid time.sleep() in laser and camera code...

@m3d m3d force-pushed the feature/timer branch from 00686ee to 16e621b Oct 17, 2018

@zwn

This comment has been minimized.

Member

zwn commented Oct 22, 2018

@m3d

This comment has been minimized.

Member

m3d commented Oct 22, 2018

bus.sleep() sounds as a good idea :-). I will refactor sicklidar, which is already using time.sleep()

@m3d m3d closed this Oct 22, 2018

@m3d m3d referenced this pull request Oct 23, 2018

Merged

Feature/bus sleep #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment