wrote pending tests - for review #212

wants to merge 1 commit into


None yet

3 participants


Could use your help in reviewing some of the specs I wrote for the pending tests. The class spec is bit messy. Basically, I struggled to get the auth && auth.persisted? block to work. Initially, I tried stubbing outside of the context block initially,

auth.stub(:persisted?).and_return true

but that had no impact on auth object created using auth_hash, so ended up writing things out and calling update_attributes directly. Your thoughts?


Coverage Status

Coverage remained the same when pulling 333a861 on dklounge:authorisation_spec into 954af5d on afternoonrobot:master.


Thanks for this @dklounge! I've only got time to leave this comment tonight but I'll take a look at this over the weekend :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment