Clean CMake for HDE V2 #87
Conversation
|
@diegoferigo Can you review the changes? |
| set(CMAKE_POSITION_INDEPENDENT_CODE ON) | ||
| endif() | ||
|
|
||
| set(CMAKE_POSITION_INDEPENDENT_CODE ON) |
There was a problem hiding this comment.
What is the rationale for this change?
There was a problem hiding this comment.
As discussed with @diegoferigo there are no cons in having it ON with BUILD_SHARED_LIBS ON
There was a problem hiding this comment.
There was a problem hiding this comment.
What is the rationale for this change?
So this was a trap?!
There was a problem hiding this comment.
So this was a trap?!
I simply forgot about what our recommended way of handling CMAKE_POSITION_INDEPENDENT_CODE was, and I had to check how-to-export-cpp-library to remember the details.
|
It is not compiling on Ubuntu 16.04. I think it is related to the compiler that is too old, iDynTree does not support it. We should have a discussion to define minimum requirements for the AnDy related software. Since there are no users beyond us and considering that it is a fairly new project (especially wearables), I would tend to be as less conservative as possible. |
I think iDynTree should have full support for Ubuntu 16.04, no?
Even if the project is new, as it is strictly related to Andy project, I think you should evaluate (depending on the future project demo), if it may make sense to consider if we need to be compatible with some environments of the project partners. A typical case with robotics academic lab is that sometimes they are bound to relatively old Ubuntu versions (not the latest LTS, for example) due to the need to remain compatible with some specific LTS ROS release. @DanielePucci |
Are you sure that the default compiler version on 16.04 is compatible with iDynTree?
We should have a meeting on this |
At least a subset of the possible configuration combinations are tested in Travis on 16.04 : https://travis-ci.org/robotology/idyntree . |
|
I probably got confused with robotology/idyntree#436. Maybe the incompatibility was before switching to docker when Travis was not yet using Ubuntu Xenial. |
|
Just to be clear, I am not opposing at all dropping support for 16.04, I just suggest to double check with @DanielePucci . |
|
@diegoferigo What is failing? |
|
@lrapetti |
Feel free to discuss this whenever you want if compilation on 16.04 will not be fixed |
|
This PR is deprecated after #100. |
|
I think we can close this PR, as after #100 it outdated. |
This PR aims to fix the CMake configuration of HDE with two improvements:
HDEv2that will depend upon wearables) 914332fWindows) d716e44