Fix segmentation fault bug in multipleanalogsensorsserver YARP device #2967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug occured once one of the device that was wrapped by multipleanalogsensorsserver did not resize the measure vector passed in the get<...>Measure call, for example because no sensor measurements were available.
traversaro
had a problem deploying
to
code-analysis
GitHub Actions
Failure
traversaro
had a problem deploying
to
code-analysis
GitHub Actions
Failure
This was referenced May 11, 2023
|
Hi @randaz81 Would it be possible to merge this PR asap? |
|
master or 3.8? |
|
yarp-3.8, thanks! |
|
The branch was correctly branched from |
randaz81
approved these changes
May 15, 2023
|
Thanks @randaz81 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug occured once one of the device that was wrapped by multipleanalogsensorsserver did not resize the measure vector passed in the
get<...>Measurecall, for example because no sensor measurements were available.The problem is solved by properly resizing the buffers before populating them, without relying on the wrapped device to do the necessary resizing.