Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI error after Github update #17

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Fix CI error after Github update #17

merged 1 commit into from
Nov 18, 2020

Conversation

audrow
Copy link
Contributor

@audrow audrow commented Nov 18, 2020

Github found a security issue and deprecated ::set-env which we were using in CI (see here). This PR addresses this issue using their proposed work around so that CI passes again.

Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
@audrow audrow added the bug Something isn't working label Nov 18, 2020
@audrow audrow self-assigned this Nov 18, 2020
@audrow audrow linked an issue Nov 18, 2020 that may be closed by this pull request
Copy link
Contributor

@emilyxzhou emilyxzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing the CI!

@audrow audrow merged commit d72952c into master Nov 18, 2020
@audrow audrow deleted the audrow/fix-ci branch November 18, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CI after Github Actions update
2 participants