/robotpy-wpilib

New issue

HAL STATUSFUNC should distinguish between warnings and errors #143

Closed
virtuald opened this Issue Feb 25, 2015 · 4 comments

Assignees

No one assigned

Labels

bug HAL

Projects

None yet

Milestone

No milestone

2 participants

@virtuald @PeterJohnson
@virtuald
Member
virtuald commented Feb 25, 2015

This bug happens particularly when accessing the PDP. See http://www.chiefdelphi.com/forums/showthread.php?t=135145 for details.
@virtuald virtuald added bug HAL labels Feb 25, 2015
@virtuald virtuald added a commit that referenced this issue Feb 25, 2015
@virtuald virtuald Don't throw errors when HAL emits a warning 
- Fixes #143
 f5ea427
@virtuald virtuald referenced this issue Feb 25, 2015
Merged

Don't throw errors when HAL emits a warning #144

@virtuald virtuald closed this in #144 Feb 25, 2015
@virtuald
Member
virtuald commented Feb 26, 2015

This bug may have happened because of wpilibsuite/allwpilib@7bdd91a ... I can't see what artf4014 is though.
@virtuald
Member
virtuald commented Feb 26, 2015

@PeterJohnson can you look at the beta tracker and see what artf4014 is?
@PeterJohnson
Member
PeterJohnson commented Feb 26, 2015

When there are multiple PCMs, reading the solenoid values from any PCM returns the value from PCM0. This is demonstrated in the attached sample programs which set PCM0 solenoid to Reverse and PCM1 solenoid to Forward. Reading both using GetAll returns 2 (reverse) for both PCM 0 and PCM1. It should return 2 for PCM0 and 1 for PCM1.

The PCM ID is not used when getting status in hal/ctre/PCM.cpp, so all status is from PCM 0
@virtuald
Member
virtuald commented Feb 26, 2015

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment