Navigation Menu

Skip to content
This repository has been archived by the owner on Nov 13, 2023. It is now read-only.

Proper logging in MotorSafety causes recursion error on Python 3.6 #560

Closed
virtuald opened this issue Jan 5, 2019 · 2 comments
Closed

Comments

@virtuald
Copy link
Member

virtuald commented Jan 5, 2019

This is a weird one. In MotorSafety.check, the logger.warning causes a weird recursion when the % is removed. In case you don't want to run all the tests, I found this reproduces the issue on 3.6.7:

wpilib/tests/run_tests.sh -x test_hal_sim.py test_motorsafety.py

Should get to the bottom of this. @ArchdukeTim mentioned that this might be caused by improper typing annotations.

@virtuald virtuald added this to To do in 2020 Season via automation Jan 5, 2019
@auscompgeek
Copy link
Member

I think we decided that this is probably due to the typing module recursing on another copy of itself that is registered with abc, since we wipe away all the modules that are loaded on each test.

@auscompgeek auscompgeek added the good first issue Good for newcomers label Oct 3, 2019
@auscompgeek
Copy link
Member

OBE.

2020 Season automation moved this from To do to Done Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
2020 Season
  
Done
Development

No branches or pull requests

2 participants