Don't throw errors when HAL emits a warning #144

Merged
merged 2 commits into from Feb 25, 2015

Projects

None yet

2 participants

@virtuald
Member

To test this, you can do the following:

git clone https://github.com/robotpy/robotpy-wpilib.git
cd robotpy-wpilib
git checkout hal-warning

On a linux/OSX system, or if you have MSYS installed on windows, you can run devtools/build_and_install.sh. If you don't have either of those, post a comment and I can write something up that will get you going.

virtuald added some commits Feb 25, 2015
@virtuald virtuald Don't throw errors when HAL emits a warning
- Fixes #143
f5ea427
@virtuald virtuald Add more instructive warning
4099911
@arilotter
Contributor

Seems to have worked for me! I deployed it and it's not crashing anymore. On the other hand, I'm not getting any HAL warnings, so the problem might just have fixed itself (CAN is weird sometimes)

@arilotter
Contributor

Even better! Just got a warning.

/usr/local/lib/python3.4/site-packages/wpilib/powerdistributionpanel.py:56: UserWarning: CTRE CAN Recieve Timeout
  return hal.getPDPTotalCurrent()

Works perfectly, thanks for the patch :)

@virtuald virtuald merged commit 8edf3fc into master Feb 25, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@virtuald virtuald deleted the hal-warning branch Feb 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment