Permalink
Browse files

Close NetworkTables client socket handles

- Fixes WPILib bug artf1727
  • Loading branch information...
1 parent 82cf190 commit 9a6ece2a79d6dafb0b117d8c97e754c012394444 @virtuald virtuald committed Mar 4, 2014
Showing with 3 additions and 1 deletion.
  1. +3 −1 networktables2/stream/SocketStreamFactory.cpp
@@ -48,6 +48,7 @@ IOStream* SocketStreamFactory::createStream(){
server = gethostbyname(host);
if (server == NULL) {
//fprintf(stderr,"ERROR, no such host\n");
+ close(sockfd);
return NULL;
}
memset(&serv_addr, 0, sizeof(serv_addr));
@@ -56,8 +57,9 @@ IOStream* SocketStreamFactory::createStream(){
serv_addr.sin_port = htons(port);
if (connect(sockfd,(struct sockaddr *) &serv_addr,sizeof(serv_addr)) < 0) {
//error("ERROR connecting");
+ close(sockfd);
return NULL;
- }//TODO close fd if an error occured
+ }
//int on = 1;
//setsockopt(sockfd, IPPROTO_TCP, TCP_NODELAY, (char *)&on, sizeof(on));

0 comments on commit 9a6ece2

Please sign in to comment.