Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added native methods for getFloat/putFloat of sun.misc.Unsafe #1100

Open
wants to merge 2 commits into
base: master
from

Conversation

@desertkun
Copy link

desertkun commented Aug 4, 2015

When I compiled kryo library for robovm I've noticed that there is no getFloat/putFloat methods in classs sun.misc.Unsafe: https://github.com/EsotericSoftware/kryo/blob/7da2f22999b8cc913fa6e9ea107aa441138bb5f1/src/com/esotericsoftware/kryo/serializers/UnsafeCacheFields.java#L84

According to the documentation this class should support this method:
http://www.docjar.com/docs/api/sun/misc/Unsafe.html#putFloat(long, float)

@ntherning ntherning added this to the 1.7 milestone Aug 13, 2015
@ntherning ntherning added the bug label Aug 13, 2015
@ntherning
Copy link
Contributor

ntherning commented Aug 13, 2015

Thanks! Did you sign our CLA?

Also, please add a note to each of the added methods in Unsafe.java:

// RoboVM note: Added in RoboVM.
@desertkun
Copy link
Author

desertkun commented Sep 3, 2015

Cmon! I was waiting for this for like a month, and now 1.8? Just a simple PR ready to merge!

@ntherning ntherning modified the milestones: 1.9, 1.8, 1.10 Sep 7, 2015
@tajny
Copy link

tajny commented Oct 9, 2015

any progress on this ?

@ollydixon
Copy link

ollydixon commented Oct 23, 2015

I have the same issue except with booleans.

@ntherning ntherning modified the milestones: 1.11, 1.10 Nov 2, 2015
@badlogic badlogic modified the milestones: 1.13, 1.11 Nov 23, 2015
@desertkun
Copy link
Author

desertkun commented Dec 24, 2015

Any news on this?

@ntherning
Copy link
Contributor

ntherning commented Jan 4, 2016

We have an open issue on closing the gap between our Unsafe and the one in the latest RI. Hopefully we can get some of this into the next release due out early February.

@ntherning ntherning modified the milestones: 1.14, 1.13 Jan 27, 2016
@ntherning ntherning modified the milestones: 1.15, 1.14 Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.