Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit YiiFirebird to the master Yii framework #7

Open
mariuz opened this issue Jan 23, 2013 · 8 comments

Comments

@mariuz
Copy link

commented Jan 23, 2013

We must commit YiiFirebird to Yii framework master branch

Please add a pull request with this driver when is ready to pushed to master

@robregonm

This comment has been minimized.

Copy link
Owner

commented Jan 23, 2013

Good idea, let me do a double check and prepare a pull request and push it to master.

@mariuz

This comment has been minimized.

Copy link
Author

commented Jan 23, 2013

some of my coleagues didn't liked that is a extension :) Thanks

@robregonm

This comment has been minimized.

Copy link
Owner

commented Jan 29, 2013

The final version 1.0 will be in the Yii master branch. It won't be long 👍
This issue will be closed when that happen.

@robregonm

This comment has been minimized.

Copy link
Owner

commented Mar 15, 2013

@mariuz @edgardmessias @ircsasw
It seems that now the extension is stable enough (please let me know it is not so) for merge in YiiFramework master repo.
Now, the next step is to create the automated tests for this extension. Volunteers? Ideas?
We need to add a "tests" directory for that purpose in our local repo before committing Yii master repo.
Example: https://github.com/yiisoft/yii/blob/master/tests/framework/db/schema/CPostgresTest.php

@edgardmessias

This comment has been minimized.

Copy link
Collaborator

commented Mar 15, 2013

How about creating a branch for this?

@robregonm

This comment has been minimized.

Copy link
Owner

commented Mar 17, 2013

Agreed!

@edgardmessias

This comment has been minimized.

Copy link
Collaborator

commented Mar 19, 2013

I created the base files.
Someone could create the SQL table creation?
Example: https://github.com/yiisoft/yii/blob/master/tests/framework/db/data/postgres.sql

@mariuz

This comment has been minimized.

Copy link
Author

commented Sep 30, 2013

This
https://gist.github.com/mariuz/6764888

is my first attempt to create the test db for yii (it was mostly created with mysql2firebird) and you can run it with

isql -b -e -m -m2 -i firebirdsql.sql

warning there is still some work to be done for types table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.