[Enhancement] create post-run dependencies ("run after") and accept other irrelevant parameters (such as description) #21

Closed
OverZealous opened this Issue Jan 19, 2014 · 6 comments

Projects

None yet

2 participants

@OverZealous

This is more for gulp, but it would be nice to be able to add short descriptions to tasks, so we could get a listing. For example, if add was called with two strings, the second string would be the description:

orchestrator.add('build-js', 'Builds and lints all JS', function(){...});

Then the description just needs to be included in the task object. Excluding task descriptions would allow us to filter out tasks that are not "top-level", too.

@robrich
Owner
robrich commented Jan 25, 2014

I'm torn. On the one hand, defining other metadata about a task that Orchestrator doesn't care about is probably easiest done here. On the other hand, Orchestrator really doesn't care about this metadata. Let me think on it.

My initial reaction is to overload orchestrator#add like so:

orchestrator.add('task', ['complete','these','tasks','first'], function (cb) { /*do this/* });

and also

orchestrator.add('task', {
  before: ['must','be','done','first'],
  after: ['queue','after','this','task'],
  other: 'things',
  that: 'orchestrator',
  ignores: 'but',
  still: 'stores'
}, function () { /* do this */});
@OverZealous

Yeah, I like overloading it like that. It becomes a "simple" merge of the passed in object data.

@OverZealous

I haven't seen any updates to orchestrator, but are you still planning on making after and before non-dependent?

My need here is for tasks that are not automatically added to the build process, but if they are added in some fashion (via other dependencies, or manually included on the command line), they have to run in a specific fashion.

(I only ask because I see before and after, but no dependsOn, so there's some ambiguity.)

@robrich
Owner
robrich commented Feb 5, 2014

I'm 1/2 way through rewriting orchestrator at the moment to solve #15, then I'll loop back to this.

@robrich robrich added the enhancement label Feb 5, 2014
This was referenced Feb 5, 2014
@robrich
Owner
robrich commented Mar 16, 2014

This is now a feature of Orchestrator's develop branch. Give it a try and see if it's sufficient.

@robrich robrich closed this Mar 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment